Skip to content

chore: improve ci workflow, ensure built parser committed, cleanup#166

Merged
erisu merged 7 commits into
masterfrom
chore/improve-ci-test-build
Jun 16, 2026
Merged

chore: improve ci workflow, ensure built parser committed, cleanup#166
erisu merged 7 commits into
masterfrom
chore/improve-ci-test-build

Conversation

@erisu

@erisu erisu commented Jun 12, 2026

Copy link
Copy Markdown
Member
  • Create npm run build script
    • Logically builds the parser
    • Automatically prefixes the built parser with the Apache-2.0 license header
  • Update npm test
    • Include linting before tests
  • Add DEVELOPMENT.md
    • Move build steps from README.md to here
    • Add more development notes
  • Clean up README.md
    • Remove the license section, as we have a LICENSE file and defined in package.json
    • Refactor the example and add some comments
  • Refactor CI workflow
    • Fail if changes are detected after running npm run build. This implies a difference between the committed and generated parser.

@erisu erisu marked this pull request as draft June 12, 2026 08:08
@erisu erisu force-pushed the chore/improve-ci-test-build branch from f661e8b to 673ab23 Compare June 16, 2026 03:20
@codecov-commenter

codecov-commenter commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (9c89212) to head (5a44930).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   97.30%   97.30%   -0.01%     
==========================================
  Files          51       51              
  Lines       10929    10928       -1     
==========================================
- Hits        10635    10634       -1     
  Misses        294      294              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu marked this pull request as ready for review June 16, 2026 03:26
@erisu erisu requested a review from dpogue June 16, 2026 04:04
@erisu erisu force-pushed the chore/improve-ci-test-build branch from 8d55c7d to 5a44930 Compare June 16, 2026 05:02
@erisu erisu merged commit ca3d1d2 into master Jun 16, 2026
17 checks passed
@erisu erisu deleted the chore/improve-ci-test-build branch June 16, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants